Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hmr reload with invalid link url #402

Merged
merged 1 commit into from
May 27, 2019

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 24, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #377 fixes #404

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #402 into master will increase coverage by 23.48%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #402       +/-   ##
===========================================
+ Coverage   64.56%   88.04%   +23.48%     
===========================================
  Files           4        4               
  Lines         412      410        -2     
  Branches       86       85        -1     
===========================================
+ Hits          266      361       +95     
+ Misses        120       47       -73     
+ Partials       26        2       -24
Impacted Files Coverage Δ
src/hmr/hotModuleReplacement.js 87.96% <100%> (+87.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9df43...998494a. Read the comment docs.

@alexander-akait
Copy link
Member Author

Need add test with external hrer link, so please do not merge right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hmr causes error [hmr] reloadStyle will trigger errors
1 participant